[PATCH] D78902: [Driver] Add output file to properties of Command

Yaxun Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Oct 5 05:18:41 PDT 2020


yaxunl added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/HIP.cpp:135
+                                         Bundler, BundlerArgs, Inputs,
+                                         InputInfo(&JA, Output.c_str())));
 }
----------------
I would suggest to use `Args.MakeArgString(OutputFileName)` instead of `Output.c_str()` to make sure it persists through the whole compilation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D78902/new/

https://reviews.llvm.org/D78902



More information about the cfe-commits mailing list