[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

[Hans Wennborg via Phabricator via cfe-commits]

hans added a comment.

In D88680#2308601 <https://reviews.llvm.org/D88680#2308601>, @zahen wrote:

> This patch doesn't need a test case outside of the one that @rnk requested to make sure that the flag flows from the clang-cl driver appropriately.  `pch-instantiate-templates` as authored doesn't match cl.exe behavior and being unable to turn it off will prevent our adoption of clang 11.  This is a release blocking issue at least for 11.1 if not 11.0 (I leave it to @hans to make the decision).  I suspect there are other users that will run into the same problem we have.
>
> Of course we'll continue to work on a reduced repro to understand where the feature and msvc diverge but that will be a follow up patch or new bug.

It's very late in the process for 11, but since this is just a flags change which seems safe, I'll consider it if we'll do another release candidate. Of course the patch has to land first :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88680/new/

https://reviews.llvm.org/D88680