[PATCH] D87256: [clangd] Avoid relations being overwritten in a header shard

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.

thanks! (and sorry for taking too long on this one.)



================
Comment at: clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp:232
 
+TEST_F(BackgroundIndexTest, RelationsMultiFile) {
+  MockFS FS;
----------------
kadircet wrote:
> nridge wrote:
> > kadircet wrote:
> > > do we still need this test?
> > I think it's still useful, yes. If someone makes a change to the way relations are stored in the future, they could regress this use case without a test specifically for it.
> this one was marked as resolved but i still don't see the reasoning. can we test this in fileindextests instead?
> 
> we already test the sharding logic, we need to test the merging logic now. can we rather test it at FileSymbols layer directly? or is there something extra that i am misisng?
okay, i still think it is better to test on FileSymbols layer but not that important.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87256/new/

https://reviews.llvm.org/D87256