[PATCH] D88469: [clangd] Heuristic resolution for dependent type and template names
Haojian Wu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Oct 5 01:22:25 PDT 2020
hokein added inline comments.
================
Comment at: clang-tools-extra/clangd/FindTarget.cpp:578
+ for (const NamedDecl *ND : getMembersReferencedViaDependentName(
+ resolveNestedNameSpecifierToType(DTST->getQualifier()),
+ [DTST](ASTContext &) { return DTST->getIdentifier(); },
----------------
we need to be robust in `resolveNestedNameSpecifierToType` -- we may get a null qualifier for DependentTemplateSpecializationType, see https://reviews.llvm.org/D76320.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88469/new/
https://reviews.llvm.org/D88469
More information about the cfe-commits
mailing list