[PATCH] D88789: [InstCombine] Revert rL226781 "Teach InstCombine to canonicalize loads which are only ever stored to always use a legal integer type if one is available." (PR47592)

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Oct 4 23:23:45 PDT 2020


lebedev.ri added a comment.

In D88789#2310967 <https://reviews.llvm.org/D88789#2310967>, @efriedma wrote:

> To address the issue at hand, I think changing the isNonIntegralPointerType() check to just isPtrOrPtrVectorTy() would be enough.  I think that might make sense?

I briefly considered that, but the motivational example in https://lists.llvm.org/pipermail/llvm-dev/2015-January/080956.html
was really about pointer-typed things. So while we could do that, i'm not sure how useful this fold really is overall.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88789/new/

https://reviews.llvm.org/D88789



More information about the cfe-commits mailing list