[PATCH] D87962: [clang] Change the multi-character character constants from extension to implementation-defined.

[Richard Smith - zygoloid via Phabricator via cfe-commits]

rsmith added inline comments.


================
Comment at: clang/include/clang/Basic/DiagnosticLexKinds.td:109
   "multi-character character constant">, InGroup<MultiChar>;
-def ext_four_char_character_literal : Extension<
+def ext_four_char_character_literal : Warning<
   "multi-character character constant">, InGroup<FourByteMultiChar>;
----------------
aaron.ballman wrote:
> One potential reason why we don't want to warn on this by default is that four char codes were quite popular back in the Mac Classic days.
Please also rename these diagnostics from ext_ to warn_.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87962/new/

https://reviews.llvm.org/D87962