[PATCH] D88518: Recognize setjmp and friends as builtins even if jmp_buf is not declared yet.
Richard Smith - zygoloid via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 2 15:12:37 PDT 2020
rsmith added a comment.
In D88518#2308085 <https://reviews.llvm.org/D88518#2308085>, @mstorsjo wrote:
> This broke use of setjmp for mingw on x86_64.
Thanks, should be fixed in rG8fb2a235b0f22dedba72b8b559ba33171a8dcd09 <https://reviews.llvm.org/rG8fb2a235b0f22dedba72b8b559ba33171a8dcd09>. Now that we properly recognize `_setjmp` even if it has a weird signature, the MSVC-specific check for exactly one argument was breaking the MinGW case. I've removed that check and instead we only apply the custom MSVC-specific codegen rule if the declaration happens to be of the right form (but we apply the `returns_twice` attribute regardless).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88518/new/
https://reviews.llvm.org/D88518
More information about the cfe-commits
mailing list