[PATCH] D88734: [HIP] Align device binary

[Artem Belevich via Phabricator via cfe-commits]

tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/tools/clang-offload-bundler/ClangOffloadBundler.cpp:374
+    auto BI = BundlesInfo[CurWriteBundleTarget];
+    OS.seek(BI.Offset);
     OS.write(Input.getBufferStart(), Input.getBufferSize());
----------------
Does the bundler anways create the file from scratch or truncate it?
If it were to operate on existing file, seek would leave some data as is and that may result in nondeterministic output.
It may be better to explicitly zero the padding.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88734/new/

https://reviews.llvm.org/D88734