[PATCH] D88590: [clangd] Add benchmark for measuring latency of DecisionForest model.

Utkarsh Saxena via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Oct 2 08:41:44 PDT 2020


usaxena95 added inline comments.


================
Comment at: clang-tools-extra/clangd/benchmarks/CompletionModel/DecisionForestBenchmark.cpp:74
+  for (auto _ : State) {
+    srand(0);
+    State.PauseTiming();
----------------
adamcz wrote:
> Move this out of the loop. Right now we re-generate "random" dataset, but it's always the same dataset ;-)
I added it inside the loop since there is only one state right now. But probably moving it out makes it more meaningful.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88590/new/

https://reviews.llvm.org/D88590



More information about the cfe-commits mailing list