[PATCH] D87256: [clangd] Avoid relations being overwritten in a header shard

[Nathan Ridge via Phabricator via cfe-commits]

nridge added a comment.

Sorry, I had a response to that comment but accidentally left it as unsubmitted...



================
Comment at: clang-tools-extra/clangd/unittests/BackgroundIndexTests.cpp:232
 
+TEST_F(BackgroundIndexTest, RelationsMultiFile) {
+  MockFS FS;
----------------
kadircet wrote:
> do we still need this test?
I think it's still useful, yes. If someone makes a change to the way relations are stored in the future, they could regress this use case without a test specifically for it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87256/new/

https://reviews.llvm.org/D87256