[PATCH] D87451: add new option ignore-xcoff-visibility

Fri Oct 2 08:00:35 PDT 2020

DiggerLin marked 5 inline comments as done.
DiggerLin added inline comments.

================
Comment at: clang/test/CodeGen/aix-no-xcoff-visibility.cpp:75
+
+// VISIBILITY-IR:    @b = protected global i32 0
+// VISIBILITY-IR:    @pramb = hidden global i32 0
----------------
jasonliu wrote:
> Not sure if the IR check is really necessary, since we haven't made any IR change here. It's going to be all the same with or without the new -m option. 
IR output will not change in the new option. I think we need to check whether the IR be changed in the new option 

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87451/new/

https://reviews.llvm.org/D87451