[clang-tools-extra] 57ac47d - [clangd] Make PopulateSwitch a fix.
Sam McCall via cfe-commits
cfe-commits at lists.llvm.org
Fri Oct 2 04:24:31 PDT 2020
Author: Sam McCall
Date: 2020-10-02T13:24:24+02:00
New Revision: 57ac47d78885c9a3d712692b1476d99840591db1
URL: https://github.com/llvm/llvm-project/commit/57ac47d78885c9a3d712692b1476d99840591db1
DIFF: https://github.com/llvm/llvm-project/commit/57ac47d78885c9a3d712692b1476d99840591db1.diff
LOG: [clangd] Make PopulateSwitch a fix.
It fixes the -Wswitch warning, though we mark it as a fix even if that is off.
This makes it the "recommended" action on an incomplete switch, which seems OK.
Differential Revision: https://reviews.llvm.org/D88726
Added:
Modified:
clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp
Removed:
################################################################################
diff --git a/clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp b/clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp
index 12a6e49a1684..a8ad90596681 100644
--- a/clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp
+++ b/clang-tools-extra/clangd/refactor/tweaks/PopulateSwitch.cpp
@@ -53,7 +53,7 @@ class PopulateSwitch : public Tweak {
Expected<Effect> apply(const Selection &Sel) override;
std::string title() const override { return "Populate switch"; }
llvm::StringLiteral kind() const override {
- return CodeAction::REFACTOR_KIND;
+ return CodeAction::QUICKFIX_KIND;
}
private:
More information about the cfe-commits
mailing list