[PATCH] D88680: Add ability to turn off -fpch-instantiate-templates in clang-cl

[Shivanshu Goyal via Phabricator via cfe-commits]

shivanshu3 added a comment.

Also, I wanted to mention that clang-cl.exe actually crashes deterministically when running precompiles for 2 of our headers when using '-fpch-instantiate-templates' with the following signature:

  1.      <eof> parser at end of file
  2.      Per-file LLVM IR generation
  3.      {msvc}\lib\native\include\xmemory:807:41: Generating code for declaration 'std::allocator<std::_Container_proxy>::allocate'
  4.      {msvc}\lib\native\include\xmemory:44:30: LLVM IR generation of declaration 'std::_New_alignof'

Once I'm able to get a smaller repro which I can share, I will update you guys with it. @llunak FYI


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88680/new/

https://reviews.llvm.org/D88680