[PATCH] D88666: DirectoryWatcher: add an implementation for Windows

[Puyan Lotfi via Phabricator via cfe-commits]

plotfi added a comment.

Overall looks good.



================
Comment at: clang/lib/DirectoryWatcher/windows/DirectoryWatcher-windows.cpp:95
+      CreateEvent(NULL, /*bManualReset=*/TRUE, /*bInitialState=*/FALSE, NULL);
+  assert(ovlIO.hEvent);
+
----------------
Can this be an assert with some message or some explanation of the hEvent return value? What happens if hEvent is non-zero on Release builds? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88666/new/

https://reviews.llvm.org/D88666