[PATCH] D88640: [Format] Don't treat compound extension headers (foo.proto.h) as foo.cc main file.

Sam McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Oct 1 05:40:13 PDT 2020


sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang/lib/Tooling/Inclusions/HeaderIncludes.cpp:237
+
+  StringRef HeaderStem =
+      llvm::sys::path::stem(IncludeName.drop_front(1).drop_back(
----------------
this deserves a comment: Not matchingStem: implementation files may have compound extensions but headers may not.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88640/new/

https://reviews.llvm.org/D88640



More information about the cfe-commits mailing list