[PATCH] D88296: [clang-format] De-duplicate includes with leading or trailing whitespace.

Marek Kurdej via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 30 12:37:36 PDT 2020


curdeius added a comment.

Thanks for the review.
I agree with you that a clang-format user should not expect a perfectly formatted code after a single iteration.
Maybe it's actually a documentation issue and we should be clear about it? Just a guarantee of 1) stability of formatting and 2) asymptotically arriving at the fully formatted code.
I'll think about how to word it and create a revision for the documentation (unless you judge it unnecessary).

BTW, I would be almost inclined to abandon this review and mark the bug report as invalid... but the change is so trivial...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88296/new/

https://reviews.llvm.org/D88296



More information about the cfe-commits mailing list