[PATCH] D88603: [WebAssembly] Add support for DWARF type units

Sam Clegg via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 30 12:07:38 PDT 2020


sbc100 accepted this revision.
sbc100 added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/MC/WasmObjectWriter.cpp:1353
       if (Begin) {
         WasmIndices[cast<MCSymbolWasm>(Begin)] = CustomSections.size();
-        if (SectionName != Begin->getName())
----------------
Just checking in the case where you were hitting this error the SectionName was duplicate but the `Begin` is uniquified ?




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88603/new/

https://reviews.llvm.org/D88603



More information about the cfe-commits mailing list