[PATCH] D88524: [CUDA][HIP] Fix bound arch for offload action for fat binary
Artem Belevich via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 30 11:03:16 PDT 2020
tra added a comment.
> Currently CUDA/HIP toolchain uses "unknown" as bound arch
> for offload action for fat binary. This causes -mcpu or -march
> with "unknown" added in HIPToolChain::TranslateArgs or
> CUDAToolChain::TranslateArgs.
It would appear that the problem is actually where we check TargetID -- we should've ignored CudaArch::UNKNOWN there.
Not setting the arch here avoids triggering the bug but it does not fix it.
Considering that `CudaArch::UNKNOWN` is used here to indicate that the arch is unused, perhaps we need an enum for that to distinguish it from unknown/unset.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88524/new/
https://reviews.llvm.org/D88524
More information about the cfe-commits
mailing list