[PATCH] D88536: [clangd] Split DecisionForest Evaluate() into one func per tree.

Adam Czachorowski via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 30 10:42:39 PDT 2020


adamcz added inline comments.


================
Comment at: clang-tools-extra/clangd/quality/CompletionModelCodegen.py:168
+        nline.join(class_members),
+        nline.join(["  float EvaluateTree%d() const;" % tree_num
+                    for tree_num in range(num_trees)]),
----------------
Why are these member functions? Why not keep them in .cc file only, in anonymous namespace?

I wonder if that will make compiler inline them and then bring back msan issues though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88536/new/

https://reviews.llvm.org/D88536



More information about the cfe-commits mailing list