[PATCH] D88472: [WIP][clangd] Support non-renaming alias underlying decls in TargetDecl.

Haojian Wu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 30 04:28:30 PDT 2020


hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1120
       namespace ns { class [[Foo]] {}; }
-      using ns::F^oo;
+      using ns::[[F^oo]];
     )cpp",
----------------
sammccall wrote:
> hokein wrote:
> > this seems a small regression, I think it is fine.
> I can't follow why this is different from the second case of
> 
> TEST_F(TargetDeclTest, UsingDecl), where the usingdecl is not reported at all.
I think you over-look it, the second case of `TEST_F(TargetDeclTest, UsingDecl)` does report the using-decl.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88472/new/

https://reviews.llvm.org/D88472



More information about the cfe-commits mailing list