[PATCH] D88470: [clangd] Extract options struct for ClangdLSPServer. NFC

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 30 00:51:27 PDT 2020


kbobyrev accepted this revision.
kbobyrev added a comment.
This revision is now accepted and ready to land.

LGTM, thanks!



================
Comment at: clang-tools-extra/clangd/ClangdLSPServer.h:56
+  // Features like indexing must be enabled if desired.
+  static Options optsForTest();
+
----------------
nit: Maybe move this to the tests? I'm not sure if this would be useful in the public interface.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88470/new/

https://reviews.llvm.org/D88470



More information about the cfe-commits mailing list