[PATCH] D87822: [FPEnv] Evaluate constant expressions under non-default rounding modes
Serge Pavlov via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 29 21:15:16 PDT 2020
The change https://reviews.llvm.org/rG4e4f926e83cf removes the problematic
test.
Sorry for troubles.
Thanks,
--Serge
On Wed, Sep 30, 2020 at 2:55 AM Petr Hosek via Phabricator <
reviews at reviews.llvm.org> wrote:
> phosek added a comment.
>
> In D87822#2301293 <https://reviews.llvm.org/D87822#2301293>, @sepavloff
> wrote:
>
> > In D87822#2301194 <https://reviews.llvm.org/D87822#2301194>,
> @leonardchan wrote:
> >
> >> Thanks for looking into it. We have that commit but it still seems to be
> >> failing for us with the same error.
> >
> > In D88498 <https://reviews.llvm.org/D88498> this test is removed
> because use of rounding mode changed. So you could just remove this test to
> fix the bot.
>
> Can we revert this change and reland it later with the fix? It's been 3
> days now and our bots are still red.
>
>
> Repository:
> rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
> https://reviews.llvm.org/D87822/new/
>
> https://reviews.llvm.org/D87822
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200930/63706174/attachment-0001.html>
More information about the cfe-commits
mailing list