[PATCH] D88333: Better diagnostics for anonymous bit-fields with attributes or an initializer
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Sep 29 13:33:01 PDT 2020
aaron.ballman closed this revision.
aaron.ballman marked 2 inline comments as done.
aaron.ballman added a comment.
Thank you for the reviews, I've committed in 538762fef0b662048be2a261ebc12da249efa977 <https://reviews.llvm.org/rG538762fef0b662048be2a261ebc12da249efa977>
================
Comment at: clang/lib/Parse/ParseDecl.cpp:4126
/// struct-declarator: declarator[opt] ':' constant-expression
- if (Tok.isNot(tok::colon)) {
+ if (Tok.isNot(tok::colon) && !isCXX11AttributeSpecifier()) {
// Don't parse FOO:BAR as if it were a typo for FOO::BAR.
----------------
rsmith wrote:
> I think this change is redundant now.
Ah, good catch! I've corrected this (and the other one).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D88333/new/
https://reviews.llvm.org/D88333
More information about the cfe-commits
mailing list