[clang-tools-extra] a9f63d2 - [clangd] Disable msan instrumentation for generated Evaluate().

Utkarsh Saxena via cfe-commits cfe-commits at lists.llvm.org
Tue Sep 29 08:47:21 PDT 2020


Author: Utkarsh Saxena
Date: 2020-09-29T17:44:10+02:00
New Revision: a9f63d22fafb0d7de768efc6b7447f8e7f6bb220

URL: https://github.com/llvm/llvm-project/commit/a9f63d22fafb0d7de768efc6b7447f8e7f6bb220
DIFF: https://github.com/llvm/llvm-project/commit/a9f63d22fafb0d7de768efc6b7447f8e7f6bb220.diff

LOG: [clangd] Disable msan instrumentation for generated Evaluate().

MSAN build times out for generated DecisionForest inference runtime.

A solution worth trying is splitting the function into 300 smaller
functions and then re-enable msan.

For now we are disabling instrumentation for the generated function.

Differential Revision: https://reviews.llvm.org/D88495

Added: 
    

Modified: 
    clang-tools-extra/clangd/quality/CompletionModelCodegen.py

Removed: 
    


################################################################################
diff  --git a/clang-tools-extra/clangd/quality/CompletionModelCodegen.py b/clang-tools-extra/clangd/quality/CompletionModelCodegen.py
index 20bfccd8806f..423e5d14cf52 100644
--- a/clang-tools-extra/clangd/quality/CompletionModelCodegen.py
+++ b/clang-tools-extra/clangd/quality/CompletionModelCodegen.py
@@ -145,6 +145,7 @@ class can be used to represent a code completion candidate.
     return """#ifndef %s
 #define %s
 #include <cstdint>
+#include "llvm/Support/Compiler.h"
 
 %s
 class %s {
@@ -160,6 +161,9 @@ class %s {
   friend float Evaluate(const %s&);
 };
 
+// The function may have large number of lines of code. MSAN
+// build times out in such case.
+LLVM_NO_SANITIZE("memory")
 float Evaluate(const %s&);
 %s
 #endif // %s


        


More information about the cfe-commits mailing list