[PATCH] D88495: [clangd] Disable msan instrumentation for generated Evaluate().

[Utkarsh Saxena via Phabricator via cfe-commits]

usaxena95 created this revision.
usaxena95 added a reviewer: adamcz.
Herald added subscribers: cfe-commits, kadircet, arphaman.
Herald added a project: clang.
usaxena95 requested review of this revision.
Herald added subscribers: MaskRay, ilya-biryukov.

MSAN build times out for generated DecisionForest inference runtime.

A solution worth trying is splitting the function into 300 smaller
functions and then re-enable msan.

For now we are disabling instrumentation for the generated function.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88495

Files:
  clang-tools-extra/clangd/quality/CompletionModelCodegen.py


Index: clang-tools-extra/clangd/quality/CompletionModelCodegen.py
===================================================================
--- clang-tools-extra/clangd/quality/CompletionModelCodegen.py
+++ clang-tools-extra/clangd/quality/CompletionModelCodegen.py
@@ -145,6 +145,7 @@
     return """#ifndef %s
 #define %s
 #include <cstdint>
+#include "llvm/Support/Compiler.h"
 
 %s
 class %s {
@@ -160,6 +161,7 @@
   friend float Evaluate(const %s&);
 };
 
+LLVM_NO_SANITIZE("memory")
 float Evaluate(const %s&);
 %s
 #endif // %s


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88495.295001.patch
Type: text/x-patch
Size: 529 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200929/36dc9b6a/attachment-0001.bin>