[PATCH] D88472: [WIP][clangd] Support non-renaming alias underlying decls in TargetDecl.

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/FindTarget.h:112
+  /// Underlying declarations for renaming alias (typedef decl, type alias decl)
+  AliasUnderlying,
+  /// Underlying declarations for non-renaming alias, decltype, etc.
----------------
The previous `Alias` vs `Underlying` were pretty nice, but they were not enough to support our non-renaming-alias-underlying case. Looking for the feedback on the API change here.  


================
Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1120
       namespace ns { class [[Foo]] {}; }
-      using ns::F^oo;
+      using ns::[[F^oo]];
     )cpp",
----------------
this seems a small regression, I think it is fine.


================
Comment at: clang-tools-extra/clangd/unittests/XRefsTests.cpp:1130
       namespace ns { int [[x]](char); int x(double); }
-      using ns::x;
+      using ns::[[x]];
       int y = ^x('a');
----------------
I think it is an improvement.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88472/new/

https://reviews.llvm.org/D88472