[PATCH] D88469: [clangd] Heuristic resolution for dependent type and template names

[Haojian Wu via Phabricator via cfe-commits]

hokein added inline comments.


================
Comment at: clang-tools-extra/clangd/FindTarget.cpp:128
 const auto ValueFilter = [](const NamedDecl *D) { return isa<ValueDecl>(D); };
+const auto TypeFilter = [](const NamedDecl *D) { return !isa<ValueDecl>(D); };
 
----------------
why not using `isa<TypeDecl>(D)`?


================
Comment at: clang-tools-extra/clangd/unittests/FindTargetTests.cpp:743
+        template <typename T>
+        void foo(typename A<T>::[[B]]);
+      )cpp";
----------------
can you try to add a nested struct C in B, and verify `typename A<T>::B::[[C]])` still works?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88469/new/

https://reviews.llvm.org/D88469