[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

Ten Tzen via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Sep 28 13:46:45 PDT 2020


tentzen added a comment.

OK, great.  
Summarize our discussion above, I will follow up with:

- rename intrinsic eha.scope.begin() with seh.scope.begin().
- update LangRef.rst with detailed explanation
- not to allow inlining under SEH direct lexical scope
- add conditional cleanup test case and make sure that eha.scope.begin() is emitted in the right place
- add sideEntry label support in AST-dumper and de/serialization.

thank you for your thorough review and valuable feedbacks.  I'm in the middle of something else. I will post another patch latter.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80344/new/

https://reviews.llvm.org/D80344



More information about the cfe-commits mailing list