[PATCH] D88377: Diagnose invalid target ID for AMDGPU toolchain for assembler

[Aaron Enye Shi via Phabricator via cfe-commits]

ashi1 added a comment.

Could you please add full context? Mostly looks good to me.



================
Comment at: clang/lib/Driver/ToolChains/HIP.cpp:243
 
-  // Allow using target ID in --offload-arch.
-  StringRef GpuArch = translateTargetID(DriverArgs, CC1Args);
+  StringRef GpuArch = getGPUArch(DriverArgs);
   assert(!GpuArch.empty() && "Must have an explicit GPU arch.");
----------------
Why move the checking logic to the end if getGPUArch doesn't do any checking?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88377/new/

https://reviews.llvm.org/D88377