[PATCH] D88329: [objc] Consolidate ObjC name mangle code to AST

[John McCall via Phabricator via cfe-commits]

rjmccall added inline comments.


================
Comment at: clang/include/clang/AST/Mangle.h:130
+                                       bool includeCategoryNamespace = true);
   void mangleObjCMethodName(const ObjCMethodDecl *MD, raw_ostream &);
 
----------------
Could you switch the polarity on the method names here, so that `mangleObjCMethodName` just mangles the method name like ObjC would and there's a `mangleObjCMethodNameAsSourceName` that appends something that obeys the Itanium source-name production?  You'll need to switch the existing call sites, of course.


================
Comment at: clang/lib/AST/Mangle.cpp:323
+  } else {
+    assert(false && "Unexpected ObjC method decl context");
   }
----------------
Prefer `llvm_unreachable`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88329/new/

https://reviews.llvm.org/D88329