[PATCH] D88296: [clang-format] De-duplicate includes with leading or trailing whitespace.

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay accepted this revision.
MyDeveloperDay added a comment.
This revision is now accepted and ready to land.

This LGTM, generally I think clang-format seems to remove trailing spaces anyway so it might be that the duplicate might disappear on the second format. but I'm good with this approach

But as a side note I keep wondering who are these people who clang-format once and expect it to be perfect!

Firstly I'm clang-format -n checking my 4-5 million lines of code every night, secondly the CI system is checking, and thirdly in our company we using clang-format on save, and Ctrl-S and :w are like a tick for me.

By the time I check my code in I've clang-formatted it 100's of times. I don't even need to use git clang-format I know its perfect already!

This is in my view the resolution to pretty much all those, I have to do it twice! bugs..its a non issue for anyone with a zero tolerance policy to un-clang-formtted code!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88296/new/

https://reviews.llvm.org/D88296