[PATCH] D88303: [clang][codegen] Remove the insertion of `correctly-rounded-divide-sqrt-fp-math` fn-attr.

Michael Liao via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 25 07:32:38 PDT 2020


hliao created this revision.
hliao added a reviewer: yaxunl.
Herald added subscribers: cfe-commits, kerbowa, Anastasia, nhaehnle, jvesely.
Herald added a project: clang.
hliao requested review of this revision.

- `-cl-fp32-correctly-rounded-divide-sqrt` is already handled in a per-instruction manner to annotate the accuracy required. There's no need to add that fn-attr. So far, there's no backend handling that attr and that option is an OpenCL-specific one, which should not be inserted everywhere.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D88303

Files:
  clang/lib/CodeGen/CGCall.cpp
  clang/test/.clang-format
  clang/test/CodeGen/complex-builtins.c
  clang/test/CodeGen/complex-libcalls.c
  clang/test/CodeGen/math-builtins.c
  clang/test/CodeGen/math-libcalls.c
  clang/test/CodeGenOpenCL/amdgpu-attrs.cl
  clang/test/CodeGenOpenCL/fpmath.cl

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D88303.294304.patch
Type: text/x-patch
Size: 6774 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20200925/cbf33f83/attachment-0001.bin>


More information about the cfe-commits mailing list