[PATCH] D87972: [OldPM] Pass manager: run SROA after (simple) loop unrolling

Roman Lebedev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Sep 25 04:05:27 PDT 2020


lebedev.ri added a comment.

In D87972#2294488 <https://reviews.llvm.org/D87972#2294488>, @xbolva00 wrote:

>>> Does that sound reasonable?
>
> Yes IMHO.
>
>>> What are the next suggested steps?
>
> It would be great to isolate and check the cases which regressed a bit.

I've rerun my benchmark, and while the results are still the same (runtime geomean -0.53%/-0.40%,
but that obviously depends on the benchmarks), there are some obvious outliers:
F13059172: image.png <https://reviews.llvm.org/F13059172>
F13059175: rsbench.txt <https://reviews.llvm.org/F13059175>
I'll try to take a look at that, assuming it's not noise.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87972/new/

https://reviews.llvm.org/D87972



More information about the cfe-commits mailing list