[PATCH] D87953: [xray] Function coverage groups

Dean Michael Berris via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 24 16:01:33 PDT 2020


dberris added a comment.

There's two tensions I'm trying to resolve in my mind with this patch:

- Is there a way to make this more deterministic, instead of using a random sampling mechanism based on the name?
- This looks like it's a subset of a more general facility to group functions by "module" or some logical grouping mechanism. Will this be superseded by a feature that allows for example to provide filters in the driver to define groupings? If so, wouldn't something like that be more flexible for your needs (group names in the IR)?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87953/new/

https://reviews.llvm.org/D87953



More information about the cfe-commits mailing list