[PATCH] D88195: Remove stale assert.

James Y Knight via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 24 13:53:33 PDT 2020


jyknight accepted this revision.
jyknight added a comment.
This revision is now accepted and ready to land.

In D88195#2293597 <https://reviews.llvm.org/D88195#2293597>, @nickdesaulniers wrote:

> In D88195#2293589 <https://reviews.llvm.org/D88195#2293589>, @void wrote:
>
>> Clarify commit message.
>
> Phabricator unfortunately won't amend the review description when the commit message is updated; you'll need to manually edit the description via phab's UI for other reviewers to observe the update. :(

You can see the description separately, under the "Commits" tab, but yea.
Also, if you use `arc diff --verbatim` to upload the new review, it'll update the review message at the same time.

  --verbatim
      When creating a revision, try to use the working copy commit
      message verbatim, without prompting to edit it. When updating a
      revision, update some fields from the local commit message.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88195/new/

https://reviews.llvm.org/D88195



More information about the cfe-commits mailing list