[clang] f8a92ad - Remove dead branch identified by @rsmith on post-commit for D88236

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 24 13:05:28 PDT 2020


Author: Erich Keane
Date: 2020-09-24T13:05:15-07:00
New Revision: f8a92adfa242a94052f583ef7b483ae1b493ebdc

URL: https://github.com/llvm/llvm-project/commit/f8a92adfa242a94052f583ef7b483ae1b493ebdc
DIFF: https://github.com/llvm/llvm-project/commit/f8a92adfa242a94052f583ef7b483ae1b493ebdc.diff

LOG: Remove dead branch identified by @rsmith on post-commit for D88236

Added: 
    

Modified: 
    clang/lib/CodeGen/CGExprConstant.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/CodeGen/CGExprConstant.cpp b/clang/lib/CodeGen/CGExprConstant.cpp
index 5b3631087f45..b0a37531dfe1 100644
--- a/clang/lib/CodeGen/CGExprConstant.cpp
+++ b/clang/lib/CodeGen/CGExprConstant.cpp
@@ -2141,15 +2141,6 @@ llvm::Constant *ConstantEmitter::tryEmitPrivate(const APValue &Value,
       Elts.push_back(C);
     }
 
-    // This means that the array type is probably "IncompleteType" or some
-    // type that is not ConstantArray.
-    if (!Filler && !NumInitElts) {
-      CommonElementType = CGM.getTypes().ConvertType(ArrayTy->getElementType());
-      llvm::ArrayType *AType =
-          llvm::ArrayType::get(CommonElementType, NumElements);
-      return llvm::ConstantAggregateZero::get(AType);
-    }
-
     llvm::ArrayType *Desired =
         cast<llvm::ArrayType>(CGM.getTypes().ConvertType(DestType));
     return EmitArrayConstant(CGM, Desired, CommonElementType, NumElements, Elts,


        


More information about the cfe-commits mailing list