[PATCH] D87451: add new clang option -mno-xcoff-visibility
Jason Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Sep 24 11:52:10 PDT 2020
jasonliu added inline comments.
================
Comment at: llvm/include/llvm/Target/TargetMachine.h:265
+ /// corresponding to -mno-xcoff-visibility.
+ bool getNoXCOFFVisibility() const { return Options.NoXCOFFVisibility; }
+
----------------
DiggerLin wrote:
> daltenty wrote:
> > This seems like it needs the corresponding comand-line option for llc added and an llc test.
> I think it will be in another separate patch.
I would actually prefer to have that in the same patch, as that would give us a full picture. It's not a huge patch even if we combine them.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87451/new/
https://reviews.llvm.org/D87451
More information about the cfe-commits
mailing list