[PATCH] D87720: Sema: add support for `__attribute__((__swift_private__))`

[Saleem Abdulrasool via Phabricator via cfe-commits]

compnerd marked 4 inline comments as done.
compnerd added inline comments.


================
Comment at: clang/include/clang/Basic/Attr.td:2189
+  let Subjects =
+      SubjectList<[Enum, Function, Struct, TypedefName,
+                   ObjCClassMethod, ObjCInstanceMethod, ObjCInterface, ObjCProperty, ObjCProtocol],
----------------
aaron.ballman wrote:
> Similar concerns here with listing all of the subjects as with the other review? (I don't have strong opinions.)
Yes, I think that is a justified concern and it would be best to not have the subject list as per the `swift_name` case.


================
Comment at: clang/test/SemaObjC/attr-swift-private.m:25
+};
+
+typedef struct { } T __attribute__((__swift_private__));
----------------
aaron.ballman wrote:
> Should also have tests for the subjects you expect not to work.
This no longer makes sense with the subject list removed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87720/new/

https://reviews.llvm.org/D87720