[PATCH] D87953: [xray] Function coverage groups

Thu Sep 24 10:08:42 PDT 2020

MaskRay added a comment.

In D87953#2293024 <https://reviews.llvm.org/D87953#2293024>, @kyulee wrote:

> I think it looks good to me. @MaskRay Any further feedback on this?

This looks good from my viewpoint. One thing remains unanswered (https://reviews.llvm.org/D87953#2284071) is how the overhead is so large that you want to have multiple groups.
Deploying N versions of an executable can bring more challenges to the build system and deployment system.

I'd want to know how you weigh the tradeoff and decide to go this route.

This is a larger stuff that I want @dberris to sign off.

================
Comment at: clang/lib/CodeGen/CodeGenFunction.cpp:815
+    if (FuncGroups > 1) {
+      const ArrayRef<uint8_t> FuncName(CurFn->getName().bytes_begin(),
+                                       CurFn->getName().bytes_end());
----------------
You can use some variants of `makeArrayRef`

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87953/new/

https://reviews.llvm.org/D87953