[PATCH] D88144: [clangd] Disable suffix matching fallback for C during include insertion

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Sep 24 01:45:58 PDT 2020


kadircet added a comment.

In D88144#2290830 <https://reviews.llvm.org/D88144#2290830>, @sammccall wrote:

> (I do wonder whether it's safe to just drop the mapping table entirely now...)

As discussed offline;
It still helps with mapping symbols missing from our cppreference extraction back to umbrella headers. Not sure how often this happens in practice anymore, but it will likely be a regression.
So gonna drop it completely in a different patch, which can be reverted quickly if things go wrong. That way we'll learn about what's currently missing, rather than masking the bugs.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88144/new/

https://reviews.llvm.org/D88144



More information about the cfe-commits mailing list