[PATCH] D88195: Remove stale assert.

James Y Knight via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 23 20:08:11 PDT 2020


jyknight added inline comments.


================
Comment at: clang/test/Modules/Inputs/asm-goto/a.h:4-6
+  asm goto("xor $0, $0\n\t"
+           "test $0, $0\n\t"
+           "jne $l1\n\t"
----------------
An empty asm string will suffice for the test.


================
Comment at: clang/test/Modules/asm-goto.cpp:1
+// RUN: rm -rf %t
+// RUN: %clang_cc1 -fmodules -fno-implicit-modules -x c++ -I%S/Inputs/asm-goto -emit-module %S/Inputs/asm-goto/module.modulemap -fmodule-name=a -o %t/a.pcm
----------------
New test seems to be failing on the autobuilders (yay pre-submit autobuilders!!) for 2 reasons:
1. C++ function-name mangling on Windows is different.
2. "$0 = callbr" != "%0 = callbr"



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88195/new/

https://reviews.llvm.org/D88195



More information about the cfe-commits mailing list