[PATCH] D80344: [Windows SEH]: HARDWARE EXCEPTION HANDLING (MSVC -EHa) - Part 1

Wed Sep 23 17:50:42 PDT 2020

rjmccall added a comment.

In D80344#2291385 <https://reviews.llvm.org/D80344#2291385>, @asmith wrote:

>> @rjmccall wrote:
>>  I think you're missing what I'm asking.  If LLVM accepts this feature, it will become our collective responsibility as a project to keep it working.  You have a large external correctness test suite for this feature.  It does not sound like you intend to open-source that test suite; instead, you intend to extract a small number of unit tests from it and add those to the LLVM test suite.  So I'm asking if you're at least going to have an external CI bot which will run the full test suite for this feature to ensure it hasn't been broken by the last day of commits.  It does not seem reasonable to expect that the few unit tests you extract will themselves be sufficient to keep the feature tested.
>
> Microsoft's SEH tests are open source and there was a suggestion in one of the threads on llvm-dev to run them on the buildbots. We can look into that as a follow on to this patch.
>
> https://lists.llvm.org/pipermail/llvm-dev/2019-November/136695.html
> https://lists.llvm.org/pipermail/llvm-dev/2020-April/140614.html

That's great.  I think that needs to be taken as more than just a suggestion, though; it's critical part of the testing story for this proposed feature.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D80344/new/

https://reviews.llvm.org/D80344