[PATCH] D87652: Sema: add support for `__attribute__((__swift_newtype__))`
Aaron Ballman via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Sep 23 13:25:54 PDT 2020
aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
The changes LGTM aside from a small wording nit with the documentation. The parser changes I asked about can be done in a follow-up to this patch.
================
Comment at: clang/include/clang/Basic/AttrDocs.td:3604-3606
+attribute appertains is imported as a new Swift type of the typedef's name. The
+``swift-wrapper`` is the old name for this attribute which is kept for
+compatibility. New uses should prefer the ``swift_newtype`` spelling.
----------------
For the new blurb about the deprecated name, how about:
Previously, the attribute was spelled `swift_wrapper`. While the behavior of the attribute is identical with either spelling, `swift_wrapper` is deprecated, only exists for compatibility purposes, and should not be used in new code.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D87652/new/
https://reviews.llvm.org/D87652
More information about the cfe-commits
mailing list