[PATCH] D87673: [clangd] Don't use zlib when it's unavailable.

Wed Sep 23 11:52:12 PDT 2020

dblaikie added a comment.

In D87673#2275940 <https://reviews.llvm.org/D87673#2275940>, @sammccall wrote:

> Thanks, this seems better than crashing.
> The practical result isn't wonderful: the two are going to fight over index files to some extent. But this can happen with different clangd versions (that use different index format versions) anyway. So this is really just graceful recovery from a bad situation.
>
> In D87673#2273347 <https://reviews.llvm.org/D87673#2273347>, @ArcsinX wrote:
>
>> Unsure about test for this
>
> Agree, testing this seems hard and not that useful.

FWIW here's how to test codepaths only reachable when zlib is not available:

./llvm/test/tools/llvm-dwp/X86/nocompress.test:

  REQUIRES: !zlib

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87673/new/

https://reviews.llvm.org/D87673