[PATCH] D54943: WIP [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

Wed Sep 23 08:51:28 PDT 2020

0x8000-0000 added a comment.

In D54943#2289410 <https://reviews.llvm.org/D54943#2289410>, @JonasToth wrote:

> In D54943#2289037 <https://reviews.llvm.org/D54943#2289037>, @0x8000-0000 wrote:
>
>> Master branch has too many false positives for tidy - would it be possible to create a branch that contains this patch set on top of llvm-11.0-rc3? I would then add this to our internal CI.
>
> Yeah, it is not that simple to get this check into something really usefull :/

Just to be clear, the false positives I was referring to are not in this checker, but other checkers (uninitialized variables mostly) that were committed to the origin/main branch.

> I can create a branch in my own fork, that would need a little work, which i can do in ~8 hours. I would then ping you.

Thank you - I tried cherry-picking the changes from the main branch onto the release branch and ... it does not build - didn't have time to debug it - and I am hoping you're more quick at making the adaptation.

>> For the legacy code (see previous reports) we found quite a few false positives. For a new code base that we're developing from scratch with C++20, there have been no false positives - it catches missed 'const' much better than human reviewers - we still keep a Clang10 around that I built from source with the previous version of the patches :)
>
> It would be great if you could keep testing your legacy code-base once this patch progresses even further.
> It is a great message, that the modern codebase does not make big trouble :) Given I tested mostly on LLVM itself so far, this is not too surprising as its a modern codebase itself.

I will keep testing on both codebases - the modern one we're using it in the CI so it gets tested vigorously. Once I get some time I'll take another pass at the legacy code base to see what it finds.

Thank you for resuming the work on this. I was afraid I'm going to lose this check when we have to move off Clang10 - (we're pursuing C++20 aggressively in the new project).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54943/new/

https://reviews.llvm.org/D54943