[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

Johannes Doerfert via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 23 07:55:07 PDT 2020


jdoerfert added inline comments.


================
Comment at: openmp/libomptarget/src/interface.cpp:161
   if (depNum + noAliasDepNum > 0)
     __kmpc_omp_taskwait(NULL, __kmpc_global_thread_num(NULL));
 
----------------
Remove this and call the nowait_mapper_loc version. Let's not duplicate logic, also below a few times.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87946/new/

https://reviews.llvm.org/D87946



More information about the cfe-commits mailing list