[PATCH] D87946: [OpenMP] Add Location Fields to Libomptarget Runtime for Debugging

Wed Sep 23 06:13:38 PDT 2020

grokos added a comment.

In D87946#2287744 <https://reviews.llvm.org/D87946#2287744>, @jhuber6 wrote:

> Seems like a hacky solution to just keep adding suffixed whenever we want a new interface though.

Yes, this used to be a point of contention within the community. We discussed the issue sometime ago and the majority of developers was in favor of this approach (as opposed to e.g. having an extra pointer to a structure which will contain additional information and which will be extended every time we add a new feature).

The libomptarget-part of this patch looks good, I'm leaving the other reviewers look at the clang-part.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87946/new/

https://reviews.llvm.org/D87946