[PATCH] D88121: [X86] Add a memory clobber to the bittest intrinsic inline asm. Get default clobbers from the target

Simon Pilgrim via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Sep 23 02:43:43 PDT 2020


RKSimon added inline comments.


================
Comment at: clang/test/CodeGen/bittest-intrin.c:50
 // X64: call i8 asm sideeffect "lock btrq $2, ($1)\0A\09setc ${0:b}", "=r,r,r,~{{.*}}"(i64* %{{.*}}, i64 {{.*}})
 // X64: call i8 asm sideeffect "lock btsq $2, ($1)\0A\09setc ${0:b}", "=r,r,r,~{{.*}}"(i64* %{{.*}}, i64 {{.*}})
 
----------------
Can you replace the regex with explicit checks for the clobbers here as well? 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88121/new/

https://reviews.llvm.org/D88121



More information about the cfe-commits mailing list