[PATCH] D87956: [WIP][IR] add fn attr for no_stack_protector; prevent inlining ssp into no-ssp

[Nick Desaulniers via Phabricator via cfe-commits]

nickdesaulniers added a comment.

I obviously have a few todos left to resolve, but CC'ing reviewers now for general feedback.

One thing I'm unsure of; it felt curious to me that nothing was enforcing that these different levels of stack protection were mutually exclusive.  I've added that here, though I could fork that out to a separate patch.  I do think it would be better if this was a "key"="value" attribute, which would simplify ensuring these were mutually exclusive (I think).  I guess that would run afoul that previous IR would no longer be forward compatible; does LLVM have a policy on IR "breaks" like that?  I guess making the mutually exclusive technically is a subtle change in behavior...should I not do that?  Or if I do, should I document that somewhere else in addition?

Does the patch itself seem to be in good shape; and does the problem it solves make sense?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87956/new/

https://reviews.llvm.org/D87956