[PATCH] D75791: [clang-format] Added new option IndentExternBlock

Tue Sep 22 00:19:38 PDT 2020

MyDeveloperDay added inline comments.

================
Comment at: clang/lib/Format/Format.cpp:746
+  Expanded.BraceWrapping.SplitEmptyRecord = true;
+  Expanded.BraceWrapping.SplitEmptyNamespace = true;
+  Expanded.IndentExternBlock = FormatStyle::IEBS_AfterExternBlock;
----------------
I didn't notice this change before... I'm not a massive fan of the code on the LHS, actually it was me that added the /*XXX=*/ to make it clearer.. however

If a new style is added to the BraceWrapping style then the code on the left I think will complain, but the code on the right will not and so its easy to miss a new default case.

Do we need to consider that?

Infact you didn't seem to change that until the very last diff! was that intentional?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75791/new/

https://reviews.llvm.org/D75791